-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing node id #22203
Merged
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/add_missing_node_id
Aug 29, 2022
Merged
add missing node id #22203
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/add_missing_node_id
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22203: Size comparison from 7e00546 to fde7aab Increases (6 builds for cc13x2_26x2, cyw30739, efr32, linux)
Decreases (9 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
bzbarsky-apple
approved these changes
Aug 26, 2022
bzbarsky-apple
approved these changes
Aug 26, 2022
PR #22203: Size comparison from 7e00546 to 70259f7 Increases (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, esp32, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
emargolis
approved these changes
Aug 29, 2022
yunhanw-google
force-pushed
the
feature/add_missing_node_id
branch
from
August 29, 2022 15:47
70259f7
to
4f76ae6
Compare
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic and
vijs
August 29, 2022 15:48
PR #22203: Size comparison from 50f9835 to 4f76ae6 Increases (8 builds for cyw30739, linux, psoc6, telink)
Decreases (2 builds for esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
andy31415
approved these changes
Aug 29, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
follow-up #21870 (comment)
Change overview
add missing node id in comment
Testing
compilation